refactoring for sending and receiving #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocheron
reviewed
Oct 28, 2019
core/Network/TLS/Sending13.hs
Outdated
| getChunks len . B.concat <$> mapM (updateHandshake13 ctx) hss | ||
| encodePacketContent (Alert13 a) = return [encodeAlerts a] | ||
| encodePacketContent (AppData13 x) = return [x] | ||
| encodePacketContent ChangeCipherSpec13 = return [encodeChangeCipherSpec] |
There was a problem hiding this comment.
packetToFragments can now be a case expression instead of using an inner function.
As consequence of the refactoring, function encodeHandshakes13 is not used anymore. We can delete it.
There was a problem hiding this comment.
You didn't mention any reason for not removing encodeHandshakes13, so I delete it too.
There was a problem hiding this comment.
Sorry. Just a mistake!
|
@ocheron Would you review this again? |
ocheron
added a commit
that referenced
this pull request
Oct 29, 2019
refactoring for sending and receiving
|
Good and merged. The simplifications about handshake encoding and processHandshake are really nice. |
|
Thank you for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches make
SendingandReceivingsymmetric as described in #392.Also, these reduce unnecessary encodings to calculate transcript hash.