Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable X448 and FFDHE groups #401

Closed
wants to merge 1 commit into from
Closed

Enable X448 and FFDHE groups #401

wants to merge 1 commit into from

Conversation

ocheron
Copy link
Contributor

@ocheron ocheron commented Oct 29, 2019

Adds remaining groups to the default configuration, ordered by x86-64 performance measured in haskell-crypto/cryptonite#204.

Security strength with FFDHE2048 is only 103 bits so I excluded this group.

@kazu-yamamoto kazu-yamamoto self-requested a review October 30, 2019 01:10
kazu-yamamoto
kazu-yamamoto approved these changes Oct 30, 2019
View reviewed changes
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested interoperability with OpenSSL and picotls. No problem was found. Let's merge this.

kazu-yamamoto added a commit to kazu-yamamoto/hs-tls that referenced this pull request Oct 30, 2019
@kazu-yamamoto
Merge PR haskell-tls#401.
3304d69
@kazu-yamamoto
Copy link
Collaborator

Rebased and merged.

@ocheron ocheron deleted the more-groups branch October 30, 2019 18:10
@ocheron
Copy link
Contributor Author

ocheron commented Oct 30, 2019

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ocheron @kazu-yamamoto