Avoid calling onServerNameIndication twice with HRR #402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TLS13 is negotiated, the callback
onServerNameIndication
in called too early in the server code flow. In case of HelloRetryRequest there is an unnecessary call for the first Client Hello. It is needed only for the second Client Hello.To avoid this, the PR moves the call to splitted implementations TLS12/TLS13:
onServerNameIndication
can be called after HRR handlingTest case "SNI" is also extended to verify that
onServerNameIndication
is called once, and thatgetClientSNI
returns a correct result on client side.