Run tests with more server versions #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously most of the tests had only one value in server supportedVersions, which is overly restrictive. This commit merges functions arbitraryPairParams and arbitraryPairParamsAt to lift this restriction but keep conditions which are useful. The filter condition (<= connectVersion) ensures connectVersion is the common version which is negotiated.
The test case "Groups" used to generate large lists of supported groups, which made very unlikely to reach the failure scenario (approx. 5% only). Limiting the list size increases probability to 25%.
kazu-yamamoto
approved these changes
Nov 5, 2019
kazu-yamamoto
added a commit
to kazu-yamamoto/hs-tls
that referenced
this pull request
Nov 5, 2019
|
Thank you for merging. The previous implementation was short and not very clear because not symmetrical. And I think it's better if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to improve the distribution of random values generated in the test suite.
Commit messages give some explanation.