Extended Master Secret #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With "extended_master_secret" extension, the master secret is derived from all handshake messages up to CKX. We need to process this handshake message before calling setMasterSecretFromPre, so this call is moved a few steps later.
RFC 7627 section 3 specifies that a client should not offer to resume a session without EMS, however this breaks session resumption with non-EMS servers. The commit relaxes this constraint when EMS is allowed and enforces it only when EMS is required.
kazu-yamamoto
added a commit
to kazu-yamamoto/hs-tls
that referenced
this pull request
Dec 4, 2019
|
Thank you for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds RFC 7627, which is a prerequisite for EKM and Token Binding before TLS 1.3.
For this I add an extensible list of flags to SessionData. Encrypted SNI would benefit from this too. It modifies the API but I think we should try this change in a minor version (not sure many people really depend on SessionData, but what is clear is that major versions tend to be blocked for months in stackage).