Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore interoperability with early Java 6 #422

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Restore interoperability with early Java 6 #422

merged 1 commit into from
Feb 17, 2020

Conversation

ocheron
Copy link
Contributor

@ocheron ocheron commented Feb 15, 2020

Some releases of J2SE 6 don't like receiving ClientHello with
zero-length extension at last position and abort the handshake with
"unexpected_message" alert.

To avoid this, the commit moves one TLS13 extension in the list sent
by a client.

Some releases of J2SE 6 don't like receiving ClientHello with
zero-length extension at last position and abort the handshake with
"unexpected_message" alert.

To avoid this, the commit moves one TLS13 extension in the list sent
by a client.
@ocheron
Copy link
Contributor Author

ocheron commented Feb 16, 2020

Additional note: the server I tested with uses FFDH groups of 768 bits, now rejected by default.

Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kazu-yamamoto added a commit to kazu-yamamoto/hs-tls that referenced this pull request Feb 17, 2020
@kazu-yamamoto kazu-yamamoto merged commit f785ce6 into haskell-tls:master Feb 17, 2020
@kazu-yamamoto
Copy link
Collaborator

Merged.

@kazu-yamamoto kazu-yamamoto mentioned this pull request Feb 19, 2020
2 tasks
@ocheron ocheron deleted the java-6 branch February 23, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants