Maximum fragment size #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library requires base >= 4.9 so the parts related to earlier versions can be removed.
Imported instances are always exported, there is no need to explicitely export them.
Replaces the maximum fragment size 16384 with a runtime variable defined when the context is initialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the constant 16384 used at multiple places with a runtime variable held by the context.
A
Nothingvalue can be used to disable fragmentation (assuming an alternative record layer is able to deal with this). The variable could be changed to IORef later, to implement extension "max_fragment_length".The PR also includes some code clean-up, mostly related to CPP.