Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUIC mode #427

Merged
merged 1 commit into from
May 6, 2020
Merged

QUIC mode #427

merged 1 commit into from
May 6, 2020

Conversation

kazu-yamamoto
Copy link
Collaborator

This explicitly defines supportedQUIC in Supported. The name might be a little bit strange. But I chose here because it is convenient to export defaultSupported with other QUIC parameters.

@kazu-yamamoto kazu-yamamoto requested a review from ocheron May 4, 2020 05:38
@ocheron
Copy link
Contributor

ocheron commented May 4, 2020

Instead of setting this through the parameters, could newQUICClient and newQUICServer set a flag directly in the Context?

Similarly ctxFragmentSize can be set to Nothing.

@kazu-yamamoto
Copy link
Collaborator Author

To redesign QUIC 0RTT, I'm putting Handshake Controller one step further. Now no ClientControl and no ClientStatus exist. I will think your suggestions together with this approach.

@ocheron
Copy link
Contributor

ocheron commented May 5, 2020

Unsure what this will be, in the meantime I submitted my work on the documentation.

@kazu-yamamoto
defining QUIC mode.
815d61c 
- Defining ctxQUICMode in Context.
- Setting ctxQUICMode to True.
- Setting ctxFragmentSize to Nothing.
- Using ctxQUICMode in Server and Client.
@kazu-yamamoto
Copy link
Collaborator Author

Due to rebase -i, I squashed all commits to a single commit. But this commit is reasonably small. Please give a look again.

ocheron
ocheron approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@ocheron ocheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The internal mode is a nice addition to replace the special values.

If possible defaultSupported should be moved out of API later. The choice of groups and ciphers is too restrictive and we usually let client decide cipher preference with help of predefined sets.

@ocheron ocheron merged commit 545fcc5 into haskell-tls:master May 6, 2020
@kazu-yamamoto kazu-yamamoto deleted the quic-mode branch May 6, 2020 20:20
@kazu-yamamoto
Copy link
Collaborator Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocheron ocheron ocheron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kazu-yamamoto @ocheron