Rework code structure for record layer #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All exceptions that are raised internally should have a defined and controlled mapping to TLS alerts. This is what TLSError provides.
The parts implementing the normal TLS record layer are moved to new modules. This adds a clear separation with the rest of the code in upper layers.
The modules are small so can be merged with the non-TLS13 modules.
kazu-yamamoto
approved these changes
May 14, 2020
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding the internal record layer API, we can reorganize the code and make a clear boundary between TLS code and the RL implementation. Content that previously existed in modules IO, Sending, Sending13 but implemented the record layer is moved to new modules Writing and Reading. Modules Sending13 / Receiving13 are small and can be merged into Sending / Receiving.
Following the change to
sendPacket, I continue to remove unneededMonadIOcontexts.And simplify a few things along the way.