Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting necessary QUIC parameters before 1RTT gets ready (2) #433

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

kazu-yamamoto
Copy link
Collaborator

This is an alternative to #432. Context is passed to sync from client and server. RTT0Status is not exported since Information has infoIsEarlyDataAccepted.

@kazu-yamamoto
Copy link
Collaborator Author

An issue: if infoIsEarlyDataAccepted is False, there is no way to tell which fallback mode is used, PreSharedKey or FullHandshake?

@ocheron
Copy link
Contributor

ocheron commented Jun 9, 2020

there is no way to tell which fallback mode is used

Yes, this is the current API, for QUIC and TLS.
The mode RTT0 is "sticky" and denote any attempt to use 0-RTT by the client.
Same, value PreSharedKey hides whether HRR was used.

Is this a problem operationally for QUIC?

Copy link
Contributor

@ocheron ocheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this approach for reasons explained previously in #432.

It's also better if "information" API to query the handshake mode or other parameters is similar between tls and quic. That doesn't mean tls API doesn't need to change too.

For operational purpose to implement QUIC protocol it could be necessary to expose more.
For example in tls the distinction RTT0Accepted / RTT0Accepted is not used but just exposed.
What is used operationally is: EarlyDataAllowed, EarlyDataNotAllowed, and RTT0Sent.

@kazu-yamamoto
Copy link
Collaborator Author

Is this a problem operationally for QUIC?

Essentially, no. But I'm afraid that users get confused.

@kazu-yamamoto
Copy link
Collaborator Author

Thank you for your review. I have merged this PR.

Since QUIC RFCs have not been published yet, we don't have to hurry up to releasing the next version for QUIC. So, we have time. Let me have more experience with this APIs.

@kazu-yamamoto kazu-yamamoto merged commit d1f30e3 into haskell-tls:master Jun 10, 2020
@kazu-yamamoto kazu-yamamoto deleted the pass-context branch June 10, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants