-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove separate Makefile. Use CMakeLists for all building/testing tasks. #51
Comments
I was taking a look into this and is the makefile even still used? I try it and it is missing I was working with the cmake file and it looks like you don't have a check for the gcc version 8 like you do in the makefile. On Ubuntu the default is 7 and when i try to use c++17 this doesn't have the header file What is the status of this issue? |
The Makefile is really only used for code coverage purposes. I've tried using a popular CMake code coverage configuration but had some difficulty. |
Just FYI @vincentlaucsb - I'm using csv-parser in a large project where all the build is managed by CMake, and I like to compile and link external libs (to improve build time for modified proprietary project files). I had an issue linking the csv-parser on MacOS. It was having issues linking the code coverage tests. I fixed it by removing this section from the CMakeLists.txt:
It would be great if there was a way to build the library for end users without running any code coverage tests (obviously a development process). |
Closing this as CMake has been used as the main build system for a while now. |
No description provided.
The text was updated successfully, but these errors were encountered: