Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link element not populating link property with GPXLink #67

Closed
davetroy opened this issue Dec 16, 2019 · 3 comments
Closed

Link element not populating link property with GPXLink #67

davetroy opened this issue Dec 16, 2019 · 3 comments

Comments

@davetroy
Copy link

Hi, I'm attempting to import a file full of waypoints that look like this:

<wpt lat="39.497486" lon="-76.232724">
  <name><![CDATA[State Of Maryland]]></name>
  <cmt><![CDATA[Near John F. Kennedy Memorial Highway (Interstate 95) , near Aberdeen, (In the median)]]></cmt>
  <desc><![CDATA[General Washington resigned his commission at Annapolis, December 23, 1783. American Revolution officially ended by Congress meeting in Annapolis, January 14, 1783. District of Columbia given to Nation, 1791. Francis Scott Key wrote "The Star-Spangled Banner," Baltimore, September, 1814. Nation's first national highway, railroad, and telegraph established in Maryland.]]></desc>
  <link href="https://www.hmdb.org/m.asp?m=25"></link>
  <sym>Waypoint</sym>
</wpt>

When I do this, the waypoint's link property is nil, while other properties are populated. Any idea what might be causing this? I would expect link to be a GPXLink and for link.href to be equal to https://www.hmdb.org/m.asp?m=25. Thanks in advance!

@vincentneo
Copy link
Owner

I’ll take a look at this issue, later today. I think it probably has something to do with the XML parser

@vincentneo
Copy link
Owner

@davetroy, so sorry! It was a silly mistake when I did the implementation of the XML parser:
I ignored the link tag when parsing all waypoint types!

Commit b777c75 should fix this.
Do update me if successful, or if some unexpected behaviour occurs.

@davetroy
Copy link
Author

That did the trick, thanks so much for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants