-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing code for show_phase + enlighten checkbox #3
Comments
Hi @posixx. The The code is actually tested, see #2 I still need to check compatibility with the D5 firmware, but I need someone to work with me on that one. Thats why the checkbox is not gone yet. But if I cannot get it to work I will remove it. Thanks for the suggestion. |
Hello @vincentwolsink. Regardless of using the same URL still these changes are needed in order to correctly setup EnvoyReader. Without these (trying without "use enlighten") i get: 2023-05-05 15:05:21.281 ERROR (MainThread) [custom_components.enphase_envoy.config_flow] Unexpected exception The class EnvoryReader needs the show_phase argument in order to have it configured. Don't know why this works for the user on #2 though.. |
Thanks for the error. Probably it was not spotted before since this code is only used during configuration of the integration during installation. I removed it from the call there. Could you try when installing the plugin from branch main @posixx ? |
Still the same error. I don't see what you are trying to achieve by removing. It is the option for showing the phase sensors or not. So this is a mandatory option and needs to be there, |
I'll do some more tests (and maybe rewrites) and will get back on this soon. |
@posixx @bes-r would be nice if you both could test 0.1.8-beta1 Next step will be implementing tests against static data, so I don't need others for that 😄 |
It's not working: |
I've asked enphase support to push D7 firmware to my device. When upgraded i will test. |
0.1.8-beta2 is working. But I'm not sure what has been changed. |
Hi @bes-r thanks for checking! Nothing much changed for the user. The checkbox during installation/configuration is no longer needed. And I rewrote a lot of code under the hood. |
@vincentwolsink if you need more testing, let me know! |
Also removed all obsolete code that was there for older firmwares. Adjusted the configuration flow accordingly. |
I cannot test the integration as i don't have D7 firmware, but there are 2 issues:
the initial show_phase is missing on EnvoyReader (lines should be inserted on line numbers):
init.py line 52:
show_phase=config.get(CONF_SHOW_PHASE, False),
envoy_reader.py:
line 104:
show_phase=False,
line 119:
self.show_phase = show_phase
Also as this integration only wotks with D7 fimrware the option "Use Enlighten" should be removed from the initial config page as this will be always true
The text was updated successfully, but these errors were encountered: