You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for creating this library (or forking and improving). I'm just getting started with Jetstream and decided to give this library a try instead of re-writing my own Nats Streaming strategy for Jetstream. I have a feature request if you are taking them? Please see below.
Request
Add an option to the ServerConsumerOptions automatically ack messages if the subscriber function executes successfully (e.g. automaticAck: true | false (Default: false)).
Benefit of Automatic Ack's
If ServerConsumerOptions. manualAck = true there is no need to invoke the context.message.ack() within each subscriber method which becomes repetitive. Developers will have the option to enable this and not have to add the ack code to each method they wish to manually ack.
This could be taken a step further by adding an additional setting that supports the nak(millis?)option to tell nats to wait (or not) and resend the message but I'm getting ahead of myself.
Suggestion
Add the NatsJetStreamServer (line 103) when the message is sent to the eventHandler by subscribing to the Observable and checking if manualAck is true then automatically ack'ing the message.
Please let me know if you have questions. I'm happy to contribute and submit a PR if you are accepting them.
Thanks,
Derek
The text was updated successfully, but these errors were encountered:
Hello 馃憢
Thanks for creating this library (or forking and improving). I'm just getting started with Jetstream and decided to give this library a try instead of re-writing my own Nats Streaming strategy for Jetstream. I have a feature request if you are taking them? Please see below.
Request
Add an option to the
ServerConsumerOptions
automatically ack messages if the subscriber function executes successfully (e.g.automaticAck: true | false (Default: false)
).Benefit of Automatic Ack's
If
ServerConsumerOptions. manualAck
=true
there is no need to invoke thecontext.message.ack()
within each subscriber method which becomes repetitive. Developers will have the option to enable this and not have to add the ack code to each method they wish to manually ack.This could be taken a step further by adding an additional setting that supports the
nak(millis?)
option to tell nats to wait (or not) and resend the message but I'm getting ahead of myself.Suggestion
Add the
NatsJetStreamServer
(line 103) when the message is sent to theeventHandler
by subscribing to theObservable
and checking ifmanualAck
istrue
then automatically ack'ing the message.Please let me know if you have questions. I'm happy to contribute and submit a PR if you are accepting them.
Thanks,
Derek
The text was updated successfully, but these errors were encountered: