Math functions #30

Brad-eki · 2019-03-25T03:07:07Z

Added:

Status

READY

To add support for GCD and LCM functions

No related issues.

git pull --prune
git checkout <feature_branch>
python
...

Added: - GCD(x1, x2) - LCM(x1, x2)

Brad-eki · 2019-03-25T03:46:20Z

Hi @vinci1it2000, which verison of numpy do you want supported? the GCD function appeared in numpy 1.15

vinci1it2000 · 2019-04-02T19:26:31Z

I have no problem. Generally I'm using the latest. We can fix numpy version >= 1.15.

If this will cause issues to others developers I'll move it as extras.

vinci1it2000 · 2019-04-13T15:22:23Z

I corrected the implementation adding tests cases.

Math functions

bd8da53

Added: - GCD(x1, x2) - LCM(x1, x2)

vinci1it2000 pushed a commit that referenced this pull request Apr 13, 2019

feat(functions), #30: Add GCD and LCM.

7b96662

vinci1it2000 added a commit that referenced this pull request Apr 13, 2019

fix(functions), #30: Correct implementation of GCD and LCM.

d4ff5ec

vinci1it2000 closed this Apr 13, 2019

vinci1it2000 self-requested a review April 13, 2019 15:24

vinci1it2000 self-assigned this Apr 13, 2019

vinci1it2000 added this to the Next Release milestone Apr 13, 2019

vinci1it2000 added the enhancement label Apr 13, 2019