Excel concat named ranges #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinci1it2000
added a commit
that referenced
this pull request
Mar 5, 2020
vinci1it2000
pushed a commit
that referenced
this pull request
Mar 11, 2020
vinci1it2000
added a commit
that referenced
this pull request
Mar 11, 2020
vinci1it2000
added a commit
that referenced
this pull request
Mar 11, 2020
There was a problem hiding this comment.
CONCAT and CONCATENATE functions were not respecting the excel implementation. I modified it according to it. I suggest adding some test cases into the test.xlsx file respecting the test matrix. It is useful to discover the full behavior of excel implementation.
Moreover, commits be8548d and b226951 does not belong to the topic of the current pullre quest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Add CONCAT and CONCATENATE excel functions.
Fix for named cells that end in numbers such as
NAMEDCELL123.If there is an error in a cell mark it as error and move on without completely erroring out.
Todos
Steps to Test or Reproduce
Tests have been added