Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug in xmatch where one check function did not return value #66

Closed
wants to merge 1 commit into from
Closed

fix bug in xmatch where one check function did not return value #66

wants to merge 1 commit into from

Conversation

jrenner
Copy link
Contributor

@jrenner jrenner commented Feb 5, 2021

in one branch in xmatch, the check function never returns a value, so the following break statement will never trigger. This means if there is more than one match in the range, the final result will be the last match, instead of the first.

vinci1it2000 pushed a commit that referenced this pull request Feb 16, 2021
@jrenner @vinci1it2000
fix(look), #66: Correct check function did not return value.
8f6dd8d
@vinci1it2000 vinci1it2000 self-assigned this Feb 16, 2021
@vinci1it2000 vinci1it2000 self-requested a review February 16, 2021 20:21
@vinci1it2000 vinci1it2000 added this to the Filicudi release milestone Feb 16, 2021
@vinci1it2000
Copy link
Owner

Thanks! I added your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinci1it2000 vinci1it2000 vinci1it2000 approved these changes

Assignees

@vinci1it2000 vinci1it2000

Labels
bug
Projects
None yet
Milestone
Filicudi release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrenner @vinci1it2000