Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoints to modify the scheduler state #182

Merged
merged 9 commits into from Mar 23, 2023

Conversation

viniciuschiele
Copy link
Owner

@mxdev88
Copy link
Contributor

mxdev88 commented Aug 22, 2021

Looks good. Could you also make the wait option available? being able to tell wait=False when shutting down the scheduler would be helpful in my use cases.

https://apscheduler.readthedocs.io/en/stable/userguide.html#shutting-down-the-scheduler

Thanks

@christopherpickering
Copy link
Collaborator

@mxdev88 I added in a option to use post json to force a shutown.

client.post(self.scheduler.api_prefix + '/shutdown', json={'wait':'False'})

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage: 77.14% and project coverage change: -1.25 ⚠️

Comparison is base (bab402b) 92.92% compared to head (a303580) 91.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
- Coverage   92.92%   91.68%   -1.25%     
==========================================
  Files           6        6              
  Lines         410      445      +35     
==========================================
+ Hits          381      408      +27     
- Misses         29       37       +8     
Impacted Files Coverage Δ
flask_apscheduler/api.py 83.05% <74.19%> (-3.16%) ⬇️
flask_apscheduler/scheduler.py 99.41% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/rst/api.rst Outdated Show resolved Hide resolved
tests/test_api.py Outdated Show resolved Hide resolved
@christopherpickering
Copy link
Collaborator

@viniciuschiele we can fix the codecov fail on another pr maybe?

@viniciuschiele
Copy link
Owner Author

Yes, I've created this issue #223

@viniciuschiele viniciuschiele merged commit e3744fa into master Mar 23, 2023
2 of 4 checks passed
@viniciuschiele viniciuschiele deleted the modify-scheduler-state branch March 23, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants