Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package requirements #51

Closed
maximtrp opened this issue Oct 5, 2021 · 2 comments
Closed

Package requirements #51

maximtrp opened this issue Oct 5, 2021 · 2 comments

Comments

@maximtrp
Copy link

maximtrp commented Oct 5, 2021 •
edited
Loading

Hello!

While reviewing your package, I have noticed that the requirements are not clearly stated anywhere (just several packages mentioned here and there). Please add such a section to your documentation and README file. You can just copy-paste the requirements from your setup.py file.

openjournals/joss-reviews#3622
@vinisalazar
Copy link
Owner

vinisalazar commented Oct 5, 2021 •
edited
Loading

Hi @maximtrp,

thank you for the issue. I have opened a PR to merge the latest version. It makes several improvements to the docs, including what you requested. I will merge it shortly.

Best,
Vini

Edit: I closed this upon the merge, but please feel free to reopen if needed.

@maximtrp
Copy link
Author

maximtrp commented Oct 5, 2021

Okay, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maximtrp @vinisalazar