#54 handle websocket rejections #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Same tests as the starlette app ones, just using the quart app
hollandjake
force-pushed
the
#54-handle-websocket-rejections
branch
2 times, most recently
from
3fd4d13
to
d145be5
Compare
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 87.56% 86.13% -1.43%
==========================================
Files 6 6
Lines 410 411 +1
==========================================
- Hits 359 354 -5
- Misses 51 57 +6
Continue to review full report at Codecov.
|
hollandjake
force-pushed
the
#54-handle-websocket-rejections
branch
2 times, most recently
from
50f2cdf
to
57c4d20
Compare
hollandjake
force-pushed
the
#54-handle-websocket-rejections
branch
from
57c4d20
to
46e139a
Compare
|
Finally got the build working, had to add numerous new tests and update a few packages as their dependencies were failing the builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54
Test classes can now receive the early termination event as a raised Exception where the body of the exception is the closure message (incase validation is wanted to be done on the response)
Also added tests for quartz WebSocket endpoints as they were missing