Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #248 #252

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Fix #248 #252

merged 1 commit into from
Sep 16, 2020

Conversation

giovannigiordano
Copy link
Contributor

@giovannigiordano giovannigiordano commented Sep 16, 2020

Closes #248

Remove replace of trailing slash to get it handled by next/link because it is configurable in next.config.js

Remove replace of trailing slash to get it handled by next/link because it is configurable in next.config.js
Copy link
Owner

@aralroca aralroca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @giovannigiordano ! LGTM!

@aralroca aralroca merged commit b797f9a into aralroca:master Sep 16, 2020
@aralroca
Copy link
Owner

@all-contributors please add @giovannigiordano for code

@allcontributors
Copy link
Contributor

@aralroca

I've put up a pull request to add @giovannigiordano! 🎉

@giovannigiordano giovannigiordano deleted the patch-1 branch September 16, 2020 14:35
@aralroca aralroca added this to the 0.17.3 milestone Sep 16, 2020
@aralroca
Copy link
Owner

@giovannigiordano I'm going to release now this under 0.17.3-canary.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch server/client error when using Next trailingSlash and Link
2 participants