Add support for nsSeparator and defaultNS

[testerez]

nsSeparator option was required so that I can use natural text as i18n keys. defaultNS was a bonus 🙂

Option	Description	Type	Default
nsSeparator	char to split namespace from key. You should set it to false if you want to use natural text as keys.	string | false	':'
defaultNS	default namespace used if not passed to useTranslation or in the translation key.	string	undefined

Also added ns prop in Tans component because I needed a way to set the namespace when nsSeparator=false

Note that those options are available in i18next:

• https://www.i18next.com/overview/configuration-options#languages-namespaces-resources
• https://react.i18next.com/latest/trans-component#trans-props

[testerez]

Hello @aralroca, could I get a review on this one 🙏
Thanks!

[aralroca]

I see everything fine @testerez. Thanks for your contribution 😊

I just have one question: is the nsSeparator required as false? If the Trans component has ns or useTranslation(ns) then it doesn't look at the separator, then when does the nsSeparator=false make sense? Thanks.

[testerez]

I just have one question: is the nsSeparator required as false? If the Trans component has ns or useTranslation(ns) then it doesn't look at the separator, then when does the nsSeparator=false make sense? Thanks.

If nsSeparator !== false then you always have the option to add a namespace in the key. It will use the first key found in this order:

1. i18Key="ns:key"
2. <Trans ns="ns" />
3. useTranslation(ns)

nsSeparator=false is required so that the key won't ever be parsed to find a namespace in it.

Does that make sense? Did I get your question right?

[aralroca]

is required so that the key won't ever be parsed to find a namespace in it

I'm still in doubt...

Ideally, the key won't ever be parsed to find a namespace in it when:

• ns param exists in Trans component: <Trans ns="ns" />
• ns param exists in useTranslation hook: useTranslation(ns)

That is to say, if the parameter ns exists it would be equivalent to nsSeparator=false and the namespace inside the key would not be looked at.

I understand that this is the current behavior. So I have trouble understanding what nsSeparator=false is doing.

Thanks 👏

[testerez]

As you can see here, I use in priority the namespace set in the key itself. Which IMO is to be expected. Since the closer to the key is the most specific. I believe this is also how i18next behaves.
Also, as I added the option to have a default namespace, you might want to declare no namespace in Trans or useTranslation. So then how would we know if the key should be parsed or not?

[aralroca]

Okay, now I understand. Thanks for the clarification, now I see it perfectly. Thank you!

[aralroca]

@all-contributors please add @testerez for code

[allcontributors]

@aralroca

I've put up a pull request to add @testerez! 🎉

[aralroca]

@testerez I prereleased this in 1.3.0-canary.4!

[aralroca]

@testerez I prereleased this in 1.3.0-canary.4!

[testerez]

Thanks @aralroca! 👏