Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add revalidate property #757

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Conversation

bmvantunes
Copy link
Contributor

@bmvantunes bmvantunes commented Jan 6, 2022

This will enable ISR (Incremental Static Regeneration). Useful when the translations leave outside the GitHub repository in a service like localazy or locize #754

@bmvantunes
Copy link
Contributor Author

Not 100% sure if I should call the property revalidate or defaultRevalidate. Any suggestions?

Copy link
Owner

@aralroca aralroca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Looks good for me!

@aralroca aralroca added this to the next release milestone Jan 6, 2022
@aralroca
Copy link
Owner

aralroca commented Jan 6, 2022

Not 100% sure if I should call the property revalidate or defaultRevalidate. Any suggestions?

Both are correct. revalidate for me is OK.
Maybe defaultRevalidate or revalidateFallback are more descriptive. However for me is better a short name with a great description because also defaultRevalidate can be confuse, because this default is only for pages without getServerSideProps or getInitialProps, etc.

@aralroca aralroca merged commit 23c0f73 into aralroca:master Jan 6, 2022
@aralroca
Copy link
Owner

aralroca commented Jan 6, 2022

@all-contributors please add @bmvantunes for code

@allcontributors
Copy link
Contributor

@aralroca

I've put up a pull request to add @bmvantunes! 🎉

@bmvantunes
Copy link
Contributor Author

Thank you very much @aralroca

PS - We forgot to pass the "revalidate" property to the webpack loader (fixed on #759)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants