Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inaccurate first brush and unrecoverable erase brush #39

Closed
lkevinzc opened this issue Aug 25, 2021 · 8 comments · Fixed by #49
Closed

inaccurate first brush and unrecoverable erase brush #39

lkevinzc opened this issue Aug 25, 2021 · 8 comments · Fixed by #49
Labels
bug Something isn't working good first issue Good for newcomers
Projects

Comments

@lkevinzc
Copy link

Describe the bug
Thanks for the v6 release with optional background image export and better erase brush! That is awesome!

I have updated the package and tried it, and found there are two minor issues (maybe not considered as bugs). Thus I hope to let you know here, and see if you could kindly provide some help.

  1. The first brush is inaccurate when it's drawn, but will become normal after the second brush. This is strange and not sure whether you could reproduce the same issue.
  2. The transparent erase function is great, but when some color brush is re-drawn on the erased area, the transparency cannot be overwritten.

To Reproduce
Directly use the component.

Screenshots

Screen.Recording.2021-08-25.at.10.33.40.AM.mov

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: chrome
@vinothpandian
Copy link
Owner

Hi @lkevinzc,

Thank you for testing it quickly. Looks like the erase is applied globally instead of locally applying to each stroke. I will try to fix it in a couple of days.

@vinothpandian vinothpandian added bug Something isn't working good first issue Good for newcomers labels Aug 25, 2021
@lkevinzc
Copy link
Author

Hi @vinothpandian , seems that the v6.0.0 is removed from the registry. May I know roughly when it will be re-published?

@vinothpandian
Copy link
Owner

@lkevinzc Sorry, I got busy with some paper deadlines. I'll come back to it by next weekend

@lkevinzc
Copy link
Author

lkevinzc commented Sep 5, 2021

@vinothpandian Good luck for your paper submissions!!
No there's nothing to be sorry :) Thank you so much for contributing your time to open-source!

@lkevinzc
Copy link
Author

Hi @vinothpandian , sorry to raise this again. Could you please give some instructions on how I can setup and develop & test locally? I would like to see if I could fix this issue and do a PR if you are still busy with your work :)

Thank you so much!

@vinothpandian
Copy link
Owner

@lkevinzc thank you for taking over. I'm using Nx setup. So you can take a look at how to run it here. But I guess I can work on it tonight or tomorrow

@vinothpandian
Copy link
Owner

@lkevinzc Check the version react-sketch-canvas@beta. It is not very performant but hope it works for your usecase.

@lkevinzc
Copy link
Author

Hi @vinothpandian , in my test now it's working quite well :)
Thanks for your time!!

@vinothpandian vinothpandian added this to Done in v6.0.2 Oct 18, 2021
@vinothpandian vinothpandian linked a pull request Oct 25, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants