Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Django 1.11 #67

Closed
karamanolev opened this issue Mar 23, 2017 · 5 comments
Closed

Support for Django 1.11 #67

karamanolev opened this issue Mar 23, 2017 · 5 comments

Comments

@karamanolev
Copy link

karamanolev commented Mar 23, 2017

Django 1.11rc1 is out now and the feature-set is frozen. Can you please add support for the new version to django-role-permissions as we want to start testing with the new release?

ValueError: invalid version number '1.11rc1'

@cinnabot
Copy link

cinnabot commented Mar 23, 2017

Hi, I have some suggestions to help solving this issue!

Here is a list of similar issues:

  1. Support multiple roles

  2. Super users should not be granted permission by default

  3. Add a management command to sync roles/permissions

  4. Exclusive use of Groups

  5. Add supported Django versions to README and docs

Also, below are some developers who made PRs that close similar issues:

Please let me know if this was useful:

Cheers,
Cinnabot.

PS: Liked my suggestions? Install me in your repository! Visit: getcinnamon.io.

@filipeximenes
Copy link
Contributor

filipeximenes commented Mar 23, 2017

Hi @karamanolev, I just pushed some changes to things that were breaking to the latest Django to master. But I could not trace where it is raising the error you mentioned. The only place it could be happening is in the __init__.py but the StrictVersion call is wrapped in a try/except and it's not supposed to raise this. Can you provide more information?
As soon as we have this sorted I can push the new compatible update to PyPI

@karamanolev
Copy link
Author

@filipeximenes I was using an older version of django-role-permissions. It should be fine. Sorry about the alarm.

@filipeximenes
Copy link
Contributor

@karamanolev full Django 11 support on PyPI as version 2.0.1

@karamanolev
Copy link
Author

@filipeximenes Thank you so much! I'll let you know if we experience issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants