Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Zone ACL #1331

Open
Aravindh-Raju opened this issue Nov 29, 2023 · 1 comment
Open

Rework Zone ACL #1331

Aravindh-Raju opened this issue Nov 29, 2023 · 1 comment
Labels
area/api Items relating to the API kind/maintenance Code cleanup, refactoring, upgrading to new shiny things

Comments

@Aravindh-Raju
Copy link
Member

Describe what you'd like to see added or improved in VinylDNS

If we add an ACL rule of read to only A records in a zone for a user/group, the user/group can still see all the records. Also, the noaccess ACL rule access level seem to have no effect. The user/group can still view zones and the content inside the zone while given noaccess ACL rule. The suitable thing to do while given a noaccess ACL rule would be to make the zone only being listed in the Zones view, but not make it viewable or access any data inside that zone.

And in the portal while an ACL user is accessing the zone, we can hide the Zone Change History tab as it should be viewable to only the owner of the zone who could update zone details.

The write and delete ACL rule access levels works as expected though. Only the read and noaccess ACL rule access levels doesn’t have proper logic and needs to be worked on.

@Aravindh-Raju Aravindh-Raju added kind/maintenance Code cleanup, refactoring, upgrading to new shiny things area/api Items relating to the API labels Nov 29, 2023
@Jay07GIT
Copy link
Member

Jay07GIT commented Jan 9, 2024

I guess, we can split the issues and open a multiple PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Items relating to the API kind/maintenance Code cleanup, refactoring, upgrading to new shiny things
Projects
None yet
Development

No branches or pull requests

2 participants