Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#168): stops browsers covering up search suggestions #170

Merged
merged 2 commits into from Jan 21, 2017
Merged

fix(#168): stops browsers covering up search suggestions #170

merged 2 commits into from Jan 21, 2017

Conversation

nodingneu
Copy link
Contributor

@nodingneu nodingneu commented Jan 21, 2017

Contributing rules

  • Fork the repo and create your branch from canary. Then be sure to put the canary branch as the target for your pull request.
  • Please be sure to follow the contributing guidelines, especially for commit message
  • Remove the Contributing rules part from this description
  • Fill out the other parts from this description

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Description

Fixes #168 where browsers were covering the search suggestions box with their own suggestions.

It used to look like this:

And now it no longer looks like that. Now the suggestions are not covered up.

http://i.cubeupload.com/IGAHcJ.png

I only had to add the HTML attribute autocomplete="off" in 3 places in 1 file.


Verification steps

Open, for example, the blog I am working on and make a few searches in Google Chrome.

After a few searches, you should notice that Google Chrome starts to cover up the suggestions with its own.

However, edit the HTML using the dev tools to include autocomplete="off" on the form and you will see the problem stops.

@nodingneu nodingneu changed the title stops browsers covering up search suggestions fix(#168): stops browsers covering up search suggestions Jan 21, 2017
@pidupuis pidupuis merged commit 5154d63 into iblh:canary Jan 21, 2017
@iblh iblh mentioned this pull request Jan 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants