Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security Issue #2

Open
Duplexes opened this issue Mar 8, 2022 · 3 comments
Open

Security Issue #2

Duplexes opened this issue Mar 8, 2022 · 3 comments

Comments

@Duplexes
Copy link

Duplexes commented Mar 8, 2022

Hello! This is a cool project.
Just a heads up anyone can run javascript code by simply inputting it into the text field. You may want to fix this.

Dupe
@viperadnan-git
Copy link
Owner

viperadnan-git commented Mar 10, 2022 •
edited
Loading

But what's the problem in this ?
We can sanitize the HTML if it's a major issue. However i wonder if sanitizing will fix it or not !

@Duplexes
Copy link
Author

People could inject bad code that could do a whole slew of things. I could add some javascript code that hooks browsers and then control them quite easily. See: https://beefproject.com/. Just convert the input to text and now just keep it raw.

@viperadnan-git
Copy link
Owner

I see, I should disable rendering javascript code. Maybe marked.js can do it on own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@viperadnan-git @Duplexes