Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal ViperConfig for ViperCoreServer #21

Open
ArquintL opened this issue Oct 28, 2020 · 0 comments
Open

Minimal ViperConfig for ViperCoreServer #21

ArquintL opened this issue Oct 28, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@ArquintL
Copy link
Member

Gobra Server has emitted the following error during CI on a Windows machine:

[scallop] Error: Validation failure for 'port' option parameters: 

Gobra Server was configured to use port 50009 but this port configuration is handled by Gobra Server and is not forwarded to ViperCoreServer (we pass an empty array of args to ViperCoreServer).
However, I couldn't find any other component that could cause the above error and I suspect ViperConfig somehow being unable to find a free port (which is the default behavior).
As ViperCoreServer does not seem to use any port (which is also not a task for ViperCoreServer), I request to remove this config option from ViperConfig and maybe move it to a separate config (e.g. ViperHttpConfig).
As part of this change, one could strip ViperConfig down to the minimum set of options that ViperCoreServer needs (and therefore call it ViperCoreServerConfig).

@ArquintL ArquintL changed the title ViperConfig.port Minimal ViperConfig for ViperCoreServer Oct 28, 2020
@ArquintL ArquintL added the enhancement New feature or request label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant