Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: Write test to exercise runPool helper #55

Open
shazow opened this issue Jul 10, 2019 · 0 comments
Open

main: Write test to exercise runPool helper #55

shazow opened this issue Jul 10, 2019 · 0 comments
Labels
Soon Candidate for the next major release

Comments

@shazow
Copy link
Member

shazow commented Jul 10, 2019

Particularly this line:

vipnode/pool.go

Line 227 in c501170

if err := handler.Register("vipnode_", p, "connect", "disconnect", "ping", "update", "peer", "client", "host"); err != nil {

Possibly convert it into an interface like

vipnode/agent.go

Lines 201 to 205 in c501170

var reverseService agent.Service = runner.Agent
rpcServer := &jsonrpc2.Server{}
if err := rpcServer.RegisterMethod("vipnode_whitelist", reverseService, "Whitelist"); err != nil {
return err
}

@shazow shazow added the Soon Candidate for the next major release label Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Soon Candidate for the next major release
Projects
None yet
Development

No branches or pull requests

1 participant