Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: max lines #13

Open
jadell opened this issue Apr 24, 2014 · 6 comments · May be fixed by #21
Open

Feature request: max lines #13

jadell opened this issue Apr 24, 2014 · 6 comments · May be fixed by #21

Comments

@jadell
Copy link

jadell commented Apr 24, 2014

It would be great to configure how many lines of text to show, if there are newlines in the text.

For example, if the total content length is less than the showChars, but there are newlines and I only want to see the first line, then a more link to show the remaining lines.

@holtkamp
Copy link

+1, a use case is when list (of features / functionality) is used for articles in a webshop and only a certain amount of lines should be displayed by default, lets say '10'.

@freeQman
Copy link

I added lines function for my req. but I dont know how to commit here, or there is other way to do it...., maybe some one can help me.....

@holtkamp
Copy link

You can simply directly edit the source code of the https://github.com/viralpatel/jquery.shorten/blob/master/src/jquery.shorten.js file using the GitHub website (use the 'pencil' icon).

When saving the file, GitHub will automatically fork (create a copy) of the code to your account and open a Pull Request to the original author.

When the autor accepts your Pull Request, your changes will be merged into the master branch.

Also see: https://help.github.com/articles/editing-files-in-your-repository/

@freeQman
Copy link

dear holtkamp
thank u for help, I committed my code smoothly ~

@holtkamp holtkamp linked a pull request Mar 31, 2015 that will close this issue
@holtkamp
Copy link

Ok, nice.

The thing you missed to do is create a Pull Request, that way you ask the maintainer of the library to adopt your code in his branch.

I did that for you now: #21

@freeQman
Copy link

oops ...... missed........
anywhere , thank u for helping me a lot 'holtkamp' ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants