Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mismatched if in CMake warning #1173

Merged
merged 1 commit into from Apr 15, 2021
Merged

Fix mismatched if in CMake warning #1173

merged 1 commit into from Apr 15, 2021

Conversation

daleglass
Copy link
Contributor

This should have no actual effect, just a warning fix. Fixes:

CMake Warning (dev) in libraries/gpu-gl/CMakeLists.txt:
  A logical block opening on the line

    /home/dale/git/vircadia/vircadia-master/libraries/gpu-gl/CMakeLists.txt:4 (if)

  closes on the line

    /home/dale/git/vircadia/vircadia-master/libraries/gpu-gl/CMakeLists.txt:6 (endif)

  with mis-matching arguments.
This warning is for project developers.  Use -Wno-dev to suppress it.

This one snuck into PR #1149

@daleglass
Fix mismatched if in CMake warning
b3db458 
This should have no actual effect, just a warning fix
@ctrlaltdavid ctrlaltdavid added the rebuild rebuild through the GithubActions label Apr 12, 2021
@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

build (ubuntu-18.04, android)

build (windows-latest, full)

@digisomni digisomni added this to In progress in 2021.1.2 Eos Release via automation Apr 14, 2021
@digisomni digisomni added this to the 2021.1.2 Eos Release milestone Apr 14, 2021
@digisomni digisomni added the CR Approved At least one code reviewer has approved the PR. label Apr 14, 2021
@digisomni digisomni merged commit 708d52c into vircadia:master Apr 15, 2021
2021.1.2 Eos Release automation moved this from In progress to Done Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulianGro JulianGro JulianGro approved these changes

Assignees
No one assigned
Labels
bugfix CR Approved At least one code reviewer has approved the PR. rebuild rebuild through the GithubActions
Projects
No open projects
2021.1.2 Eos Release
Done
Milestone
2021.1.2 Eos Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@daleglass @vircadia-build-notifier @JulianGro @ctrlaltdavid @digisomni