Remove unnecessary loop sending octree packets to a known node.

[odysseus654]

OctreeEditPacketSender can either send a packet (list) to a specific node or all nodes. In all cases it is currently looping through all known nodes and checking to see if they match the filter criteria before processing the request.

This patch splits the search into a for loop if doing all nodes and a direct-retrieve if the node is known.

This should be a very small optimization (saving for loop and functor call over every known node) but it might be significant if this function gets called a lot (once for every entity change? It's heavily optimized down the line already) and with a larger number of active users.

I have not done any testing outside of an interface smoketest (which doesn't even touch this line of code).

Testing focus: This patch changes the code responsible for changing entities in the domain, both storing messages before a user is fully connected and sending packets once they are. The actions affected by this change are:

• PacketType::EntityAdd - an entity with the specified properties is added to the domain
• PacketType::EntityEdit - an entity has had one or more properties changed (e.g. edited or changed by script)
• PacketType::EntityPhysics - an entity has had one or more properties changed by the physics engine
• PacketType::EntityErase - an entity has been removed from the domain
• PacketType::EntityClone - an entity has been cloned from an existing entity in the domain

[digisomni]

Testing: Please mess with entities on a local domain to see if anything broke, if everything works as expected then the PR should be fine. :)

[odysseus654]

Probably even better if two people are on the domain, one person messes with the entities and the other person should see the same messing.

[vircadia-build-notifier]

The following links are available:
build (macOS-10.15, client)

• https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1353/Vircadia-Interface-PR1353-56f190a-_099bf16d.dmg

build (macOS-10.15, full)

• https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1353/Vircadia-PR1353-56f190a-_099bf16d.dmg

build (ubuntu-18.04, full)

• https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1353/Vircadia-PR1353-56f190a-.tar_099bf16d.gz
• https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1353/Vircadia-PR1353-56f190a-_099bf16d.sh
• https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1353/Vircadia-PR1353-56f190a-.tar_099bf16d.Z

build (windows-latest, full)

• https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1353/Vircadia-PR1353-56f190a-_099bf16d.exe

[digisomni]

I think she works!