Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the deprecated QMutex{ QMutex::Recursive} with QRecursiveMutex (solves approximately 1700 warnings). #1367

Merged
merged 1 commit into from Oct 1, 2021
Merged

Replace the deprecated QMutex{ QMutex::Recursive} with QRecursiveMutex (solves approximately 1700 warnings). #1367

merged 1 commit into from Oct 1, 2021

Conversation

daleglass
Copy link
Contributor

This fixes around 1700 warnings.

HifiExperiments
HifiExperiments approved these changes Sep 26, 2021
View reviewed changes
Copy link
Collaborator

@HifiExperiments HifiExperiments left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that’s all? 😆

@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, client)

build (windows-latest, full)

build (macOS-latest, full)

@digisomni digisomni added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Sep 26, 2021
@digisomni digisomni added this to In progress in 2022.1.0 Selene Release via automation Sep 26, 2021
@digisomni digisomni added this to the 2021.2.0 Selene Release milestone Sep 26, 2021
@digisomni digisomni added the housekeeping Code or documentation cleanup label Sep 30, 2021
2022.1.0 Selene Release automation moved this from In progress to Reviewer approved Oct 1, 2021
digisomni
digisomni approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@digisomni digisomni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to work alright after running the Interface and Domain server.

@digisomni digisomni added QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing labels Oct 1, 2021
@digisomni digisomni changed the title Replace the deprecated QMutex{ QMutex::Recursive} with QRecursiveMutex Replace the deprecated QMutex{ QMutex::Recursive} with QRecursiveMutex (solves approximately 1700 warnings). Oct 1, 2021
@digisomni digisomni merged commit 939d095 into vircadia:master Oct 1, 2021
2022.1.0 Selene Release automation moved this from Reviewer approved to Done Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HifiExperiments HifiExperiments HifiExperiments approved these changes

@digisomni digisomni digisomni approved these changes

Assignees
No one assigned
Labels
CR Approved At least one code reviewer has approved the PR. housekeeping Code or documentation cleanup QA Approved The PR has been tested successfully. Qt
Projects
No open projects
2022.1.0 Selene Release
Done
Milestone
2022.1.0 Selene Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@daleglass @vircadia-build-notifier @HifiExperiments @digisomni