Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transform uses placeholderPattern: false #163

Merged
merged 1 commit into from Feb 9, 2020

Conversation

jeremyjh
Copy link
Contributor

@jeremyjh jeremyjh commented Feb 7, 2020

We explicitly disable placeholderPatterns to prevent compilation errors
of valid Vue.js templates using Babel 7 transform.

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines: CONTRIBUTING.md
  • There are no linting errors and code is properly formatted (your run before push yarn lint)
  • Tests for the changes have been added (for bug fixes / features)
  • [] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

You can see in the failing test case that a valid Vue.js template is not compiled successfully if it has all caps alone between two-tags. Babel transform assumes this is the start of a placeholder pattern unless it is explicitly told not to do that.

image

What is the new behavior?

Valid Vue.js templates are always compiled.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

This issue is referenced here:

babel/babel#8067

We explicitly disable placeholderPatterns to prevent compilation errors
of valid Vue.js templates using Babel 7 transform.
babel/babel#8067
@codecov-io
Copy link

codecov-io commented Feb 7, 2020

Codecov Report

Merging #163 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #163   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines           6      6           
=====================================
  Hits            6      6
Impacted Files Coverage Δ
test/fixtures/FooComponent.vue 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77774d...11ec757. Read the comment docs.

@vire vire self-assigned this Feb 9, 2020
@vire vire merged commit e73fb5b into vire:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants