Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add navigation by ArrowUp/ArrowDown #4

Merged
merged 1 commit into from May 25, 2021
Merged

add navigation by ArrowUp/ArrowDown #4

merged 1 commit into from May 25, 2021

Conversation

adirtyshame
Copy link

i just saw your post on dev.to and found your project interesting.
by reading through the code i found your "todo" regarding navigation by arrow keys.
my pull request does the following:

  • the input field and the emoji buttons are getting a tabindex attribute
  • the seach function uses filter() instead of if
  • i remember the length of the filtered emojis (line 39)
  • i added a keydown listener, where i test for ArrowUp or ArrowDown
    cheers
    thomas

@virejdasani
Copy link
Owner

Thank you SO much, this is exactly what Geniemoji needed!
Going ahead with the merge!

@virejdasani virejdasani merged commit 2573927 into virejdasani:master May 25, 2021
@virejdasani virejdasani added the Feature New feature label May 25, 2021
@adirtyshame
Copy link
Author

adirtyshame commented May 25, 2021 via email

@virejdasani
Copy link
Owner

virejdasani commented May 25, 2021

Kaomoji support would be really cool. Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants