Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#48, two new dependence function #49

Merged
merged 15 commits into from
Jan 30, 2020
Merged

Issue#48, two new dependence function #49

merged 15 commits into from
Jan 30, 2020

Conversation

ahaselsteiner
Copy link
Member

Implemented two new dependence functions, one function is called 'logistics4' and one function is called 'alpha3'. Changes on the architecture of viroconcom where necessary as the architecture was built to support only dependence functions with 3 parameters (see issue #48).

However, 'logistics4' has 4 parameters.

'alpha3' required even more changes as this function includes a logistics4 function. Thus, it has actually 7 parameters, but only 3 of the 7 seven parameters are fitted.

These functions were implemented to support the wind-wave model that was proposed in the publication 'Global hierarchical models for wind and wave contours'. The original implementation was in Matlab and is available here: https://github.com/ahaselsteiner/2020-paper-omae-hierarchical-models

@coveralls
Copy link

coveralls commented Jan 27, 2020

Pull Request Test Coverage Report for Build 381

  • 90 of 90 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.06%) to 89.228%

Totals Coverage Status
Change from base Build 363: 2.06%
Covered Lines: 1052
Relevant Lines: 1179

💛 - Coveralls

@ahaselsteiner ahaselsteiner merged commit eb5e3df into master Jan 30, 2020
@ahaselsteiner
Copy link
Member Author

After a brief discussion with @kawindme we decided to merge the pull request. We will make this a new release.

@ahaselsteiner ahaselsteiner deleted the issue#48 branch January 30, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants