Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update requirements txt #75

Merged
merged 8 commits into from
Aug 21, 2020
Merged

Update requirements txt #75

merged 8 commits into from
Aug 21, 2020

Conversation

kawindme
Copy link
Collaborator

Update python version to 3.8 and the dependencies in requirements.txt to up to date versions.

@coveralls
Copy link

coveralls commented Aug 21, 2020 •
edited

Pull Request Test Coverage Report for Build 597

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 88.641%
Files with Coverage Reduction New Missed Lines %
viroconcom/conftest.py 3 83.33%
Totals Coverage Status
Change from base Build 580: -0.08%
Covered Lines: 1389
Relevant Lines: 1567
💛 - Coveralls

ahaselsteiner
ahaselsteiner requested changes Aug 21, 2020
View reviewed changes
Copy link
Member

@ahaselsteiner ahaselsteiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have two comments/questions:

  1. Why have additional packages been added to rquirements.txt?
  2. Should we specify minimum version numbers in setup.py?

requirements.txt Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
@kawindme kawindme merged commit ba13115 into master Aug 21, 2020
@kawindme kawindme deleted the update_requirements_txt branch August 21, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahaselsteiner ahaselsteiner ahaselsteiner requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kawindme @coveralls @ahaselsteiner