Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the way to specify response group without placing it in URL params #47

Closed
asvishnyakov opened this issue Dec 28, 2017 · 5 comments
Closed

Comments

@asvishnyakov
Copy link
Contributor

asvishnyakov commented Dec 28, 2017

Currently, if you want to load some parts of product, you must specify resp_group query in URL. We must found the way to specify it in theme.

@asvishnyakov
Copy link
Contributor Author

asvishnyakov commented Dec 28, 2017

@OlegoO @IgorisB If you have any comments/ideas about this issue, please, write here

@asvishnyakov asvishnyakov changed the title Get all needed response groups from theme settings Make the way to specify response group without placing it in URL params Dec 28, 2017
@tatarincev tatarincev removed their assignment Feb 2, 2018
@asvishnyakov
Copy link
Contributor Author

asvishnyakov commented Feb 5, 2018

Possible solution: use "| resp_group" liquid filter, constants for every response group and "| plus: " operator for combining response group values.

How it will work:

{% assign current_product_resp_group: product_resp_group.properties | plus: product_resp_group.editorial_reviews %}
{% for product in collection.products | resp_group: current_product_resp_group %}
{{ product | resp_group: current_product_resp_group | json }}
{% assign current_collection_resp_group: collection_resp_group.properties | plus: collection_resp_group.seo %}
{% for collection in collection.parents | resp_group: current_collection_resp_group %}
{{ collection | resp_group: current_collection_resp_group | json }}

@asvishnyakov
Copy link
Contributor Author

@tatarincev How much more time we need to fix it? Requested by client project

@tatarincev tatarincev self-assigned this Sep 4, 2018
@tatarincev
Copy link
Contributor

The new syntax to how we can change search criteria for data queries from Liquid templates

{% paginate collection.products by 5 params {"ResponseGroup":"ItemLarge"} %}

@tatarincev
Copy link
Contributor

alexbobrob pushed a commit to alexbobrob/VirtoCommerce-Storefront-ASP.NET that referenced this issue Mar 31, 2022
breactpyndev pushed a commit to breactpyndev/Angular-flask that referenced this issue Apr 6, 2022
johnebennet pushed a commit to johnebennet/Azure-vc-storefront that referenced this issue Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants