Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes in default themes to avoid incompatibilities with old storefront version #8

Closed
tatarincev opened this issue Sep 21, 2017 · 1 comment
Assignees

Comments

@tatarincev
Copy link
Contributor

tatarincev commented Sep 21, 2017

Add {% Layout %} tag to all templates which are don't use default layout
Checkout, Account

Change Page.liquid template to always render static content
{% layout page.layout %} {{ page.content | render }}

Add to templates\customers\reset_password.liquid new lines

	  <input type="hidden" value="{{ reset_password.token }}" name="customer[token]" id="token">
	  <input type="hidden" value="{{ reset_password.email }}" name="customer[email]" id="email">
``` for correct password reset

(optional) Now instead CustomerInfo we are using User type which encapsulated  Contact as property need to change all js and templates according to this fact. Also, these changes affected the Cart and QuoteRequest model. 
List of files for change:  `Checkout.liquid`, `main.js`, `account.js` and other 
@Woland2k
Copy link
Contributor

Why is this needed? Need to discuss further. We need to make old themes completely compatible without any changes.

@tatarincev tatarincev self-assigned this Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants