Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✅ [Issue-1] Add Navbar #18

Merged
merged 7 commits into from
Jun 16, 2022
Merged

feat: ✅ [Issue-1] Add Navbar #18

merged 7 commits into from
Jun 16, 2022

Conversation

Rana-Paul
Copy link
Collaborator

@Rana-Paul Rana-Paul commented Jun 15, 2022 •
edited by unnikrishnan2002
Loading

🛠️ Fixes Issue

Closed #1

👨‍💻 Changes proposed

✔️ Check List (Check all the applicable boxes)

  • [ ✔️] My code follows the coding standards of this project.
  • [✔️] This PR does not contain plagiarized content.
  • [ ✔️] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

nav

apoorv-on-git
apoorv-on-git requested changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@apoorv-on-git apoorv-on-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are .svg files for? Use icons instead. Fontawesome is already imported into the project.

unnikrishnan2002
unnikrishnan2002 suggested changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@unnikrishnan2002 unnikrishnan2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stick to the coding standards of this project. Your css properties should be in alphabetical order. Also, put a blank line at the end of the css file.

@unnikrishnan2002 unnikrishnan2002 changed the title Issue 1 feat: ✅ [Issue-1] Add Navbar Jun 16, 2022
@Rana-Paul
Copy link
Collaborator Author

ok I will change it

@Rana-Paul
Copy link
Collaborator Author

I fix all the issues. please review my code.

apoorv-on-git
apoorv-on-git approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@apoorv-on-git apoorv-on-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @unnikrishnan2002 take a look once.

@unnikrishnan2002
Copy link
Contributor

Looks good to me. @unnikrishnan2002 take a look once.

Yep, should I test it once in my system ?

unnikrishnan2002
unnikrishnan2002 approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@unnikrishnan2002 unnikrishnan2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@apoorv-on-git apoorv-on-git merged commit ff1d74d into main Jun 16, 2022
@apoorv-on-git apoorv-on-git deleted the issue-1 branch June 16, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorv-on-git apoorv-on-git apoorv-on-git approved these changes

@unnikrishnan2002 unnikrishnan2002 unnikrishnan2002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navbar
3 participants
@Rana-Paul @unnikrishnan2002 @apoorv-on-git