Bug: 'Account Plan' and 'Edit Owner Limits' pages do not match

[shoulders]

SYSTEM INFORMATION
OS type and version	Ubuntu Linux 22.04.3
Webmin version	2.101
Usermin version	2.001
Virtualmin version	7.8.2
Theme version	21.04
Package updates	8 package updates are available, of which 1 is security update

The issue overview

The following 2 pages do not match:

• Virtualmin -->Administration Options --> Edit Owner Limits --> Server Owner Limits
• Virtualmin -->System Settings --> Account Plans -->'any plan' --> Edit Account Plan

This can be confusing because the settings in Account Plans are pushed to this page, so they should match so the end users can match the settings in Account Plans to those applied on the Server Owner Limits page.

There is also inconsistency in the naming of the options.

Why should you fix this

This will make using Account Plans easier to use because the option names will match and the page layouts will be the same, but now organised into better categories. Going forwards it will be a lot easier to add new options into the account plan and owner limits.

Specific Issues

• The accordion headings are different
  • 'Edit Account Plan'
    • Basic plan details
    • Allowed virtual server features
    • Allowed capabilities
  • 'Server Owner Limits'
    • Virtualmin limits for server owner
    • Allowed capabilities and features
    • Other restrictions (this is fine as is, but really it's settings should either be in an account plan or a server template)
• **Different Option names **
• the options under Basic plan details and virtualmin limits for server owner are different
• Default available features are different on each page
  • in Server Owner Limits this is called Edit capabilities for virtual servers
  • in Server Owner Limits this is in Allowed capabilities and features not Allowed virtual server features
  • Automatic, based on initial features should be renamed to Automatic, if people want to know why they should look a the tooltip
  • the location of this section is wrong, it should be before capabilities
  • there
• Default editing capabilities are different on each page
  • in Server Owner Limits this is called Allowed features for servers
  • in Server Owner Limits this is in Allowed capabilities and features not Allowed capabilities
  • The location of this section is wrong. It should be after features.
• In account plans, there are extra options in 'Allowed Virtual server features'
  • These are present in Account Plans but not in the Server Owner Limits page
    • Administration user
    • Home directory
    • Apache SSL website
    • Log file rotation

Solution

I have done some mockups (below) of each of the pages and then listed the changes. I can supply the originals before I made the mockups, I just did not want to overload the initial request.

I think you will find these new pages much easier to understand and should mostly be a cosmetic change.

Inconsistencies I could not remedy between the two pages

• Server owner
  • has Maximum allowed sub-servers and aliases, Edit Account Plan does not have an equivalent unless it is Maximum allowed virtual servers, in which case I have already renamed this this to be Maximum allowed virtual servers.
  • has an extra option called Sub-servers inherit IP address from parent - should this be in the Account Plan as-well, if not it might need it's own section or putting in Other restrictions.

Edit Account Plan

• split Basic plan details into:
  • Plan Details
  • Quotas and Bandwidth
  • Limits
  • Options
• renamed Allowed virtual server features accordion header to Features
• renamed Allowed capabilities accordion header to Permissions
• in Limits i renamed:
  • Limit on number of users --> Maximum allowed users
  • Limit on number of aliases --> Maximum allowed email aliases
  • Limit on number of databases --> Maximum allowed databases
  • Limit on number of virtual servers --> Maximum allowed virtual servers
  • Limit on number of non-alias servers --> Maximum allowed sub-servers
  • Limit on number of alias servers --> Maximum allowed alias servers
• in Features
  • I added a red star next to each one not present in Server Owner Limits page.
    • Administration user
    • Home directory
    • Apache SSL website
    • Log file rotation
  • I renamed Automatic, based on initial features --> Automatic. Users should look at the tooltip as to what this means
• in Permissions
  • I renamed Automatic, based on other limits --> Automatic. Users should look at the tooltip as to what this means

Server Owner Limits

• i have split Virtualmin limits for server owner accordion heading into Limits and Options
• in Limits
  • I have renamed Maximum allowed sub-servers and aliases -->Maximum allowed virtual servers I took a guess on this one
  • I have renamed Maximum allowed aliases --> Maximum allowed alias servers
• i have split Allowed capabilities and features accordion heading into Features and Permissions