Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] proper dist output #37

Closed
mixvar opened this issue Nov 21, 2020 · 2 comments · Fixed by #70
Closed

[build] proper dist output #37

mixvar opened this issue Nov 21, 2020 · 2 comments · Fixed by #70
Assignees
Labels
feature New feature or improvement of existing feature
Projects
Milestone

Comments

@mixvar
Copy link
Collaborator

mixvar commented Nov 21, 2020

research & implement the most appropriate way to generate /dist folder to make the lib consumable for widest possible audience.

@mixvar mixvar added this to To do in FormTS via automation Nov 21, 2020
@mixvar mixvar added this to the 1.0 milestone Nov 21, 2020
@mixvar mixvar added the feature New feature or improvement of existing feature label Nov 29, 2020
@pidkopajo pidkopajo moved this from To do to In progress in FormTS Jan 11, 2021
@pidkopajo pidkopajo self-assigned this Jan 11, 2021
@dgreene1
Copy link

dgreene1 commented Feb 9, 2021

I used https://github.com/formium/tsdx for that. It automatically builds esm modules and I think a couple of other types via Rollup. If you let it scaffold your repo it also handles the correct package.json info so that users are informed which file to get from dist.

I recognize that the repo has already been scaffolded, but it’s a pretty easy lift to scaffold again and then put the src dir back in. Let me know if you need help. At the current moment I don’t have time to contribute, but that might change later. I wanted to at least share the TSDX tip.

@mixvar
Copy link
Collaborator Author

mixvar commented Feb 9, 2021

Thanks @dgreene1, It makes sense to look at TSDX. I was sceptical of generating entire repo and went for manual setup but maybe it makes more sense to do as you say. Or we can manually apply build config used by tsdx

@pidkopajo pidkopajo linked a pull request Feb 24, 2021 that will close this issue
FormTS automation moved this from In progress to Done Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or improvement of existing feature
Projects
Development

Successfully merging a pull request may close this issue.

3 participants