perf: reuse the network writer used for rpc parameters

MirrorNetworking · Jun 16, 2019 · 5dafc4d · 5dafc4d
1 parent cc6e4f6
commit 5dafc4d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/Assets/Mirror/Editor/Weaver/Processors/NetworkBehaviourProcessor.cs b/Assets/Mirror/Editor/Weaver/Processors/NetworkBehaviourProcessor.cs
@@ -107,7 +107,8 @@ public static void WriteSetupLocals(ILProcessor worker)
         public static void WriteCreateWriter(ILProcessor worker)
         {
             // create writer
-            worker.Append(worker.Create(OpCodes.Newobj, Weaver.NetworkWriterCtor));
+            worker.Append(worker.Create(OpCodes.Call, Weaver.GetArgWriterMethod));
+            //worker.Append(worker.Create(OpCodes.Newobj, Weaver.NetworkWriterCtor));
             worker.Append(worker.Create(OpCodes.Stloc_0));
         }
 

diff --git a/Assets/Mirror/Editor/Weaver/Weaver.cs b/Assets/Mirror/Editor/Weaver/Weaver.cs
@@ -57,6 +57,7 @@ class Weaver
         public static TypeReference SyncDictionaryType;
 
         public static MethodReference NetworkBehaviourDirtyBitsReference;
+        public static MethodReference GetArgWriterMethod;
         public static TypeReference NetworkClientType;
         public static TypeReference NetworkServerType;
 
@@ -341,6 +342,7 @@ static void SetupTargetTypes()
             SyncDictionaryType = NetAssembly.MainModule.GetType("Mirror.SyncDictionary`2");
 
             NetworkBehaviourDirtyBitsReference = Resolvers.ResolveProperty(NetworkBehaviourType, CurrentAssembly, "syncVarDirtyBits");
+            GetArgWriterMethod = Resolvers.ResolveProperty(NetworkBehaviourType, CurrentAssembly, "GetArgWriter");
 
             ComponentType = UnityAssembly.MainModule.GetType("UnityEngine.Component");
             ClientSceneType = NetAssembly.MainModule.GetType("Mirror.ClientScene");

diff --git a/Assets/Mirror/Runtime/NetworkBehaviour.cs b/Assets/Mirror/Runtime/NetworkBehaviour.cs
@@ -74,6 +74,14 @@ protected void InitSyncObject(SyncObject syncObject)
             syncObjects.Add(syncObject);
         }
 
+        private static NetworkWriter argWriter;
+        protected static NetworkWriter GetArgWriter()
+        {
+            argWriter = argWriter ?? new NetworkWriter();
+            argWriter.SetLength(0);
+            return argWriter;
+        }
+
         #region Commands
         [EditorBrowsable(EditorBrowsableState.Never)]
         protected void SendCommandInternal(Type invokeClass, string cmdName, NetworkWriter writer, int channelId)