feat: NetworkSceneChecker use Scene instead of string name #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why is this better? |
Because scene name is not unique when loading the same additive multiple times, while the Scene itself is a unique instance. |
sounds like this would be worth a comment in the code. it's not obvious now, even less so 5 years from now :) |
|
@vis2k Done |
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Feb 27, 2020
# [11.1.0](11.0.0-master...11.1.0-master) (2020-02-27) ### Bug Fixes * Add missing channelId to NetworkConnectionToClient.Send calls ([#1509](https://github.com/MirrorNG/MirrorNG/issues/1509)) ([b8bcd9a](b8bcd9a)) * build in IL2CPP ([#1524](https://github.com/MirrorNG/MirrorNG/issues/1524)) ([59faa81](59faa81)), closes [#1519](https://github.com/MirrorNG/MirrorNG/issues/1519) [#1520](https://github.com/MirrorNG/MirrorNG/issues/1520) * Fixed NetworkRoomManager Template ([1662c5a](1662c5a)) * Fixed toc link ([3a0c7fb](3a0c7fb)) * Host Player Ready Race Condition ([#1498](https://github.com/MirrorNG/MirrorNG/issues/1498)) ([4c4a52b](4c4a52b)) * NetworkIdentity.SetClientOwner: overwriting the owner was still possible even though it shouldn't be. all caller functions double check and return early if it already has an owner, so we should do the same here. ([548db52](548db52)) * NetworkServer.SpawnObjects: return false if server isn't running ([d4d524d](d4d524d)) * properly detect NT rotation ([#1516](https://github.com/MirrorNG/MirrorNG/issues/1516)) ([f0a993c](f0a993c)) * return & continue on separate line ([#1504](https://github.com/MirrorNG/MirrorNG/issues/1504)) ([61fdd89](61fdd89)) * Room example to use new override ([e1d1d41](e1d1d41)) * SendToAll sends to that exact connection if it is detected as local connection, instead of falling back to the .localConnection field which might be something completely different. ([4b90aaf](4b90aaf)) * SendToObservers sends to that exact connection if it is detected as local connection, instead of falling back to the .localConnection field which might be something completely different. ([4267983](4267983)) * SendToReady sends to that exact connection if it is detected as local connection, instead of falling back to the .localConnection field which might be something completely different. ([4596b19](4596b19)) ### Features * Added NetworkConnection to OnRoomServerSceneLoadedForPlayer ([b5dfcf4](b5dfcf4)) * Check for client authority in CmdClientToServerSync ([#1500](https://github.com/MirrorNG/MirrorNG/issues/1500)) ([8b359ff](8b359ff)) * Check for client authority in NetworkAnimator Cmd's ([#1501](https://github.com/MirrorNG/MirrorNG/issues/1501)) ([ecc0659](ecc0659)) * Cosmetic Enhancement of Network Manager ([#1512](https://github.com/MirrorNG/MirrorNG/issues/1512)) ([f53b12b](f53b12b)) * NetworkSceneChecker use Scene instead of string name ([#1496](https://github.com/MirrorNG/MirrorNG/issues/1496)) ([7bb80e3](7bb80e3))
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Feb 27, 2020
* NetworkSceneChecker use Scene instead of string name * Added comment
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Feb 27, 2020
# [11.1.0](11.0.0-master...11.1.0-master) (2020-02-27) ### Bug Fixes * Add missing channelId to NetworkConnectionToClient.Send calls ([#1509](https://github.com/MirrorNG/MirrorNG/issues/1509)) ([b8bcd9a](b8bcd9a)) * build in IL2CPP ([#1524](https://github.com/MirrorNG/MirrorNG/issues/1524)) ([59faa81](59faa81)), closes [#1519](https://github.com/MirrorNG/MirrorNG/issues/1519) [#1520](https://github.com/MirrorNG/MirrorNG/issues/1520) * Fixed NetworkRoomManager Template ([1662c5a](1662c5a)) * Fixed toc link ([3a0c7fb](3a0c7fb)) * Host Player Ready Race Condition ([#1498](https://github.com/MirrorNG/MirrorNG/issues/1498)) ([4c4a52b](4c4a52b)) * NetworkIdentity.SetClientOwner: overwriting the owner was still possible even though it shouldn't be. all caller functions double check and return early if it already has an owner, so we should do the same here. ([548db52](548db52)) * NetworkServer.SpawnObjects: return false if server isn't running ([d4d524d](d4d524d)) * properly detect NT rotation ([#1516](https://github.com/MirrorNG/MirrorNG/issues/1516)) ([f0a993c](f0a993c)) * return & continue on separate line ([#1504](https://github.com/MirrorNG/MirrorNG/issues/1504)) ([61fdd89](61fdd89)) * Room example to use new override ([e1d1d41](e1d1d41)) * SendToAll sends to that exact connection if it is detected as local connection, instead of falling back to the .localConnection field which might be something completely different. ([4b90aaf](4b90aaf)) * SendToObservers sends to that exact connection if it is detected as local connection, instead of falling back to the .localConnection field which might be something completely different. ([4267983](4267983)) * SendToReady sends to that exact connection if it is detected as local connection, instead of falling back to the .localConnection field which might be something completely different. ([4596b19](4596b19)) ### Features * Added NetworkConnection to OnRoomServerSceneLoadedForPlayer ([b5dfcf4](b5dfcf4)) * Check for client authority in CmdClientToServerSync ([#1500](https://github.com/MirrorNG/MirrorNG/issues/1500)) ([8b359ff](8b359ff)) * Check for client authority in NetworkAnimator Cmd's ([#1501](https://github.com/MirrorNG/MirrorNG/issues/1501)) ([ecc0659](ecc0659)) * Cosmetic Enhancement of Network Manager ([#1512](https://github.com/MirrorNG/MirrorNG/issues/1512)) ([f53b12b](f53b12b)) * NetworkSceneChecker use Scene instead of string name ([#1496](https://github.com/MirrorNG/MirrorNG/issues/1496)) ([7bb80e3](7bb80e3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Scene instead of scene name because additive subscenes may be loaded at once and the name won't be unique.