Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Team Interest Management #2979

Merged
merged 8 commits into from
Oct 29, 2021
Merged

feat: Team Interest Management #2979

merged 8 commits into from
Oct 29, 2021

Conversation

MrGadget1024
Copy link
Collaborator

This can be used to show certain spawned items to a subset of players having a common teamID.

  • For example a team resource or team-based stats for a UI, where team mates can see each other's health or other info but are not given any data on members of the other team.
  • This could also be used to show spawned objects to a single client, replacing Network Owner Checker

This is very similar to Match Interest Management but differs in the following:

  • If no NetworkTeam component, the object is shown to all clients instead of none.
  • NetworkTeam component has a forceShown bool that overrides matching the teamID.
    • This would typically be enabled for Player objects so they can all see each other.

Fixes #2914
Fixes #2915

@MrGadget1024 MrGadget1024 added enhancement New feature or request Awaiting Review labels Oct 29, 2021
miwarnec
miwarnec approved these changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@miwarnec miwarnec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MrGadget1024 MrGadget1024 merged commit 1a43b79 into master Oct 29, 2021
@MrGadget1024 MrGadget1024 deleted the TeamInterestManagement branch December 17, 2021 22:46
@MrGadget1024 MrGadget1024 restored the TeamInterestManagement branch December 17, 2021 22:46
@MrGadget1024 MrGadget1024 deleted the TeamInterestManagement branch December 17, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miwarnec miwarnec miwarnec approved these changes

Assignees
No one assigned
Labels
Awaiting Review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Owner-Only Network Visibility Team Interest Management
2 participants
@MrGadget1024 @miwarnec