SetClientReady() spawns observers if no player

[fuqunaga]

With #609, SpawnObserversForConnection() is now called in AddPlayerForConnection().
But there can be a case that no player.

• clients just watch the server local play
• just synchronize parameters like non-game applications

So if no player, SetClientReady() calls SpawnObserversForConnection().

[miwarnec]

Can't you just spawn a player object for spectators too?

[fuqunaga]

Yes, but i think it is good to work without a player unless it need a player.
It was working in UNET, people switching may be confused.

[MrGadget1024]

Yes, but i think it is good to work without a player unless it need a player.
It was working in UNET, people switching may be confused.

It was a security hole in UNet. You can spawn an empty GO for the observer. It's AddPlayerForConnection where authentication happens, so until the client passes that step they should get nothing from the server other than messages explicitly related to authentication and setup.

[fuqunaga]

It was a security hole in UNet. You can spawn an empty GO for the observer. It's AddPlayerForConnection where authentication happens, so until the client passes that step they should get nothing from the server other than messages explicitly related to authentication and setup.

I understand.
Thanks:)