Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] [Small] Align viewport keyframes with deck.gl #230

Open
3 tasks
chrisgervang opened this issue May 10, 2022 · 1 comment
Open
3 tasks

[Proposal] [Small] Align viewport keyframes with deck.gl #230

chrisgervang opened this issue May 10, 2022 · 1 comment
Assignees
@chrisgervang
Labels
good first issue Good for newcomers

Comments

@chrisgervang
Copy link
Collaborator

  • Rename CameraKeyframes to MapViewKeyframes. The "fly to" interpolator isn't relevant to other views.
  • Add OrbitViewKeyframes
  • Add FirstPersonViewKeyframes
@chrisgervang chrisgervang self-assigned this May 10, 2022
@chrisgervang chrisgervang added the good first issue Good for newcomers label Jul 6, 2022
@chrisgervang chrisgervang changed the title [Proposal] Align viewport keyframes with deck.gl [Proposal] [Small] Align viewport keyframes with deck.gl Jul 7, 2022
@chrisgervang
Copy link
Collaborator Author

While in there, for MapViewKeyframes, test that all viewState properties can be interpolated or are filtered out. For example, position: [number, number, number] and normalize: boolean aren't supported by popmotion interpolate out of box and throw a "not a valid mixer" error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisgervang chrisgervang

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisgervang