Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document gltf Uber extension strings #65

Closed
twojtasz opened this issue Jan 30, 2019 · 2 comments
Closed

Document gltf Uber extension strings #65

twojtasz opened this issue Jan 30, 2019 · 2 comments

Comments

@twojtasz
Copy link
Contributor

Strings here modules/gltf/src/gltf/gltf-builder.js must be known and documented to access this data.

@ibgreen
Copy link
Collaborator

ibgreen commented Jan 30, 2019

Since these are common to both builder and parser we should probably have a separate doc uber-gltf-extensions.md that describes the extensions we implement and in cases where they are unique to us, their semantics.

We can reference this doc in the two other class-specific docs.

However, the idea was to implement addCompressedPointCloud and getCompressedMesh to hide the need to use the extension names from the app (but I understand that from a file format documentation point of view, it is desirable to document them, though I might consider them somewhat experimental at this stage).

@ibgreen
Copy link
Collaborator

ibgreen commented Mar 13, 2019

Done

@ibgreen ibgreen closed this as completed Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants