Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate geometry (attributes) from Model #45

Closed
ibgreen opened this issue Mar 4, 2016 · 1 comment
Closed

Separate geometry (attributes) from Model #45

ibgreen opened this issue Mar 4, 2016 · 1 comment

Comments

@ibgreen
Copy link
Collaborator

ibgreen commented Mar 4, 2016

Our model knows how to combine programs (shaders), attributes and uniforms.

It is also the base class for our geometric primitives (planes, cylinders, spheres etc). But geometric primitives are typically only a set of attributes and some props like drawType.

A separate geometry or attributes class that can be installed on a Model might be a more flexible setup, that would allow the overly broad Model class to become more focused.

Also compare attributes.js in deck.gl performance branch, it could be a good base for a geometry/attributes class.

@mikolalysenko

@ibgreen
Copy link
Collaborator Author

ibgreen commented May 25, 2016

This is implemented on dev branch

@ibgreen ibgreen closed this as completed May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant